aristanetworks / sonic

Open source drivers and initialization library for Arista platforms running SONiC
GNU General Public License v2.0
22 stars 30 forks source link

[Wolverine LC] wrong thermal numbers returned from chassis api #68

Closed wenyiz2021 closed 1 year ago

wenyiz2021 commented 1 year ago

[platform_tests/api/test_chassis.py:403: Failed]

try:
num_thermals = int(chassis.get_num_thermals(platform_api_conn))
except:
pytest.fail("num_thermals is not an integer")
else:
if num_thermals == 0:
pytest.skip("No thermals found on device")
if duthost.facts.get("chassis"):
expected_num_thermals = len(duthost.facts.get("chassis").get('thermals'))
pytest_assert(num_thermals == expected_num_thermals,
"Number of thermals ({}) does not match expected number ({})"
>                         .format(num_thermals, expected_num_thermals))
E           Failed: Number of thermals (2) does not match expected number (6)
wenyiz2021 commented 1 year ago

@Staphylo I believe platform.json is correct as you specified for each of the 6 thermals. Can you please check the chassis api? thanks

Staphylo commented 1 year ago

I believe the correct number is 2 on Wolverine. The platform.json needs to be updated. @patrickmacarthur

wenyiz2021 commented 1 year ago

@Staphylo @patrickmacarthur can you please remove the 4 thermal entries in platform.json? or let me know what need to be removed, I can create one

patrickmacarthur commented 1 year ago

I have a patch for this that I will submit upstream today.

patrickmacarthur commented 1 year ago

PR opened: https://github.com/sonic-net/sonic-buildimage/pull/13524