aristidb / aws

Amazon Web Services for Haskell
BSD 3-Clause "New" or "Revised" License
238 stars 107 forks source link

Moves from Signature V2 to Signature V4 for S3 #199

Closed angerman closed 6 years ago

angerman commented 8 years ago

This PR so far adds support for:

It additionally does:

It also introduces a breaking API change, as Endpoints are replaced by Regions. I tried to keep these as similar to those provided in DynamoDb.

It should fix #167

angerman commented 8 years ago

Data.Bifunctor, was introduced in base-4.8.

angerman commented 8 years ago

Looks like I broke the google storage nearline example.

angerman commented 8 years ago

This might eventually break google storage support? I'm not certain about that, and I don't have a gcs account nor did I find detailed documentation on the S3 compatibility.

aristidb commented 8 years ago

To keep compatibility with Google, maybe put a SignatureVersion field into the S3Config? Then the google config can just say "V2 signing please".

aristidb commented 8 years ago

And do I understand it correctly that you consider your pull request complete and ready for merging when you have ticked off all the checkboxes, @angerman ?

angerman commented 8 years ago

I guess that would be optimal. Though I must admit, I don't see this getting finished soon. Especially multi-part seems to be quite tricky to get right.

aristidb commented 6 years ago

Superseded by #241