search

aristippe / pathagar

Pathagar is a simple bookserver serving OPDS feeds
GNU General Public License v2.0
1 stars 1 forks source link

Post upgrade cleanup #30

Closed sinergatis closed 8 years ago

sinergatis commented 8 years ago

Fix a number of small issues found during migration, listed on #4.

sinergatis commented 8 years ago

Feel free to merge if it looks ok (most of them are pretty small changes, other than the pretty-printing bonus on the commands added because ... why not? :trollface: ), or otherwise postpone if further changes are required or if they interfere with the merging of the features you might be working on!

aristippe commented 8 years ago

Looks good. Thanks! I like that addepub now outputs status of how many imported. Perhaps in the future, some summary count of how many already exist, and perhaps a summary output of which files weren't imported would be helpful for troubleshooting, and just be nice to have.

One of my earlier changes to output identifier in addepub possibly can be later removed. I used to think the epub identifier was a good way to detect duplicates; it is required though it's not always specified (along with other fields sometimes) so another way like the original method of hash seems ok.