aristippe / pathagar

Pathagar is a simple bookserver serving OPDS feeds
GNU General Public License v2.0
1 stars 1 forks source link

Unify BookEditView and AddBookWizard step 2 views #44

Closed sinergatis closed 8 years ago

sinergatis commented 8 years ago

Make BookEditView and AddBookWizard share the template and the forms (by making BookMetadataForm a subclass of BookEditForm), plus cleanup the templates, forms, and related stuff in the process. This should make the code more maintainable and allow for further changes in the edit/import functionality easier to keep in sync, as discussed at #39.

The changes on books/epub.py (and in turn commands/addepub.py) revert some previous changes that were not handled properly: when modifying models or epub.py, it's important to make sure it does not break things elsewhere - as we do not have proper tests for the UI yet, please do be careful and check manually when introducing such changes!

Things that would need work in further iterations:

sinergatis commented 8 years ago

Merged - as usual, please review whenever you have the chance and follow up if needed (in particular due to the lack of makemessages and possible dancing around of the translation strings).