aristocratos / bashtop

Linux/OSX/FreeBSD resource monitor
Apache License 2.0
10.76k stars 549 forks source link

Add graphs for memory and file system #73

Open Naheel-Azawy opened 4 years ago

Naheel-Azawy commented 4 years ago

Is your feature request related to a problem? Please describe. Not a problem.

Describe the solution you'd like Add a graph that show the memory usage and a graph that shows the file system usage.

Describe alternatives you've considered I usually use conky, here's my config. But I was thinking of removing the panel from my conky config, I like things to be clean. So I was thinking of something like what you did and it is what I need I guess.

Additional context Awesome work btw!

aristocratos commented 4 years ago

I had a graph for memory in the first versions before release but choose against it because memory is seldom jumping a lot and didn't seem useful to have a graph that was just flat 99% of the time. Opted to use meters instead to also fit more information.

To fit in a graph now would either only show on very large terminal sizes or I would have to cut away swap information to show on lower sizes.

File system usage is not polled at the moment. It has been requested to be included. But what I had in mind was possibly current Read and Write per disk, next to the title of the disk, to not take up too much vertical space.

Could possibly have a option to toggle a one line disk usage graph.

Naheel-Azawy commented 4 years ago

Maybe make them configurable?

aristocratos commented 4 years ago

Added current disk read and write speeds in v0.8.19 But sorry, no graphs yet.

Naheel-Azawy commented 4 years ago

Awesome thanks!!

lamyergeier commented 4 years ago

@aristocratos You mentioned:

I had a graph for memory in the first versions before release but choose against it because memory is seldom jumping a lot and didn't seem useful to have a graph that was just flat 99% of the time.

But the graphs might be useful to identify which process misbehaved. It is usually flat but can be used to identify anomalies. May be enduser has an option to toggle swap on or off, so that they could fit in graph.

aristocratos commented 4 years ago

The memory graph was for all system memory and if the were to be a big spike in memory usage, most likely there would also be a corresponding spike in the cpu usage, still wouldn't tell which process is the offender.

The graphs are also very cpu heavy so I don't think the trade off with a couple of seconds of history would be worth it.