search

aristocratos / btop

A monitor of resources
Apache License 2.0
21.38k stars 656 forks source link

[BUG] User theme files miscounted (Fedora 39, btop 1.2.13) #694

Open RedBearAK opened 11 months ago

RedBearAK commented 11 months ago

I have a Fedora 39 system where I used the JaKooLit Fedora-Hyprland script to set up Hyprland. I can't recall if I installed btop prior to setting up Hyprland, or if it was installed by the Hyprland setup script. The Hyprland script does install some "catpuccin" themes for btop, in ~/.config/btop/themes.

One of those themes is set as the default by the JaKooLit script. But looking in the btop options, it says this theme is "33/32", and after changing the theme it's impossible to change back to the original "catpuccin_macchiato" theme. There are a total of four theme files installed in the local user location. The location seems to be correct.

Copying those same theme files into the /usr/share/btop/themes location alongside the built-in btop themes causes btop to show a total of 36 themes, and all the "catpuccin_" themes can be selected in the usual manner. Deleting them from /usr/share/btop/themes/ causes them to no longer appear in the btop options, even though the same files are in ~/.config/btop/themes.

Nothing strange shows up in the log when running with "--debug".

The btop version is 1.2.13 and it's installed as a native Fedora package.

RedBearAK commented 11 months ago

Turns out this is some sort of "counting" problem, and the user themes were there all along, but they were numbers 2-6 on the list of themes and when I first entered the options screen it said the theme that was selected was number 33 (out of 32), so I got dumped at the very end of the list (32) and got VERY confused when I couldn't seem to go back or forward to get back to the original theme (which was actually theme 5 of 32).

RedBearAK commented 11 months ago

This problem crops up when I set the theme manually in the btop.conf file. Once again the theme was shown as "33/32", and then the "33" disappeared when I moved to a different theme in the options screen.

Also seems to require setting a "user" theme manually. Setting one of the default themes from /usr/share/btop/themes/ as the theme manually in the conf file doesn't seem to trigger this issue. I chose "nord.theme" and it was shown as "24/32" as it should be.