search

aristofanio / maven-android-plugin

Automatically exported from code.google.com/p/maven-android-plugin
0 stars 0 forks source link

Unpacked-embedded-jars included in APK #433

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Add a project dependency (scope compile)
2. Add another project dependency (scope compile) with a duplicated file
3. This triggers ApkMojo#removeDuplicatesFromJar - which creates a folder 
"unpacked-embedded-jars" in {output}/classes containing the modified 
de-duplicated second project
4. ApkMojo#doAPKWithAPKBuilder adds {output}/classes to the APK's "source" 
folders (second statement in the method)
5. Final APK will include the "unpacked-embedded-jars" folder including the jar 
of the de-duplicated file. This folder (and its jar) seems to be redundant, 
because everything is already included in the classes.dex

What is the expected output?
An APK without the redudant jars.

What do you see instead?
An APK including a folder "unpacked-embedded-jars" with alot of useless 
.class-files packed in jars.

What version of maven-android-plugin are you using?
3.8.0

What are the complete output lines of "mvn -version" on your machine?
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 
17:22:22+0200)
Maven home: C:\Users\hans\Documents\apache-maven-3.1.1
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home: C:\jdk1.7\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

Please provide any additional information below.
I'm new to Maven and building Android with Maven, therefore be gentle with me. 
Maybe there are cases where the "unpacked-embedded-jars" folder is needed in 
the output APK. Maybe because of resources other than the included .class files?

Original issue reported on code.google.com by hugotheg...@gmail.com on 30 Nov 2013 at 5:22

GoogleCodeExporter commented 9 years ago 
Test against 3.8.3-SNAPSHOT

If the failure stills occurs then provide a project or link to a project that 
clearly highlights the failure.

Original comment by william....@xandar.com.au on 17 Feb 2014 at 11:12

GoogleCodeExporter commented 9 years ago 
Hugo, can you please test against 3.9.0-rc.1

Original comment by william....@xandar.com.au on 27 Feb 2014 at 10:31

GoogleCodeExporter commented 9 years ago 
Hugo can you please provide a project showing the failure.
If not, I'm going to close this off.

Original comment by william....@xandar.com.au on 10 Mar 2014 at 11:52

GoogleCodeExporter commented 9 years ago 
I'm sorry to say that I don't work in the project anymore. Therefore I'm 
currently not able to check the fix. I've contacted the guys of my former 
company hoping that they can give me a statement on this issue!

Original comment by hugotheg...@gmail.com on 13 Mar 2014 at 4:30

GoogleCodeExporter commented 9 years ago

Original comment by william....@xandar.com.au on 13 Mar 2014 at 9:55

GoogleCodeExporter commented 9 years ago 
Marking as invalid until/unless we get a project showing the problem.

Original comment by william....@xandar.com.au on 22 Mar 2014 at 1:21