aritchie05 / EcoCraftingTool

Crafting calculator for Eco.
https://eco-calc.com
MIT License
23 stars 12 forks source link

Certain recipes are producing specific items instead of tags as intended #52

Closed aritchie05 closed 2 years ago

aritchie05 commented 2 years ago

For example, Hewn Logs recipe should produce HewnLog tag rather than the specific item HewnLogItem. This is because there are multiple recipes that use HewnLog tag as an ingredient rather than the specific item (HewnLogItem, SoftwoodHewnLogItem, etc.)

I believe the following items are affected by this, it was accidentally changed when the recipes were updated for 9.5. Any item which produces different variants is probably affected. (e.g. Softwood & Hardwood)

HewnLog Boards Lumber CompositeLumber AshlarStone

aritchie05 commented 2 years ago

This causes an issue where the output price is not correctly considered for other recipes. For example, price of BU1 should be automatically considering the output price of Hewn Logs here, but it is not because the HewnLogs recipe output is HewnLogItem, rather than HewnLog (tag). And the BU1 recipe uses HewnLog (tag) as ingredient.

image

rannmann commented 2 years ago

Well done!

aritchie05 commented 2 years ago

@rannmann I believe the issue should auto-close when the commit is merged into the default branch (master). I am curious if it works like that