aritchie05 / EcoCraftingTool

Crafting calculator for Eco.
https://eco-calc.com
MIT License
23 stars 12 forks source link

Infinite loop here when removing table with unmet dependencies #88

Closed ankemp closed 1 year ago

ankemp commented 1 year ago

https://github.com/aritchie05/EcoCraftingTool/blob/d0d747d552b9890af2f9e2b485b882a442422434/src/app/crafting-parent/crafting-parent.component.ts#L605

Steps to recreate:

Think its related to unmet item dependency. Probably need to switch from single array of items, to dependency tree or track array of item dependencies in each item to check if they exist in the items array, if they dont skip (or dont try to recalc)

aritchie05 commented 1 year ago

Thanks for reporting, this issue was introduced in the last patch due to performance changes that were not fully tested. Reverted for now.