Bugfix - From line is not showing up on mobile devices

arithmetric / aws-lambda-ses-forwarder

Serverless email forwarding using AWS Lambda and SES

MIT License

1.7k stars 450 forks source link

Bugfix - From line is not showing up on mobile devices #108

Open vagifzeynalov opened 5 years ago

jontro commented 4 years ago

See https://stackoverflow.com/questions/3644081/what-is-the-format-for-e-mail-headers-that-display-a-name-rather-than-the-e-mail for more info

arithmetric commented 4 years ago

Thanks for this contribution @vagifzeynalov. I agree that it is better to have quotes around the name part of the From header.

However I think this PR needs additional changes to handle quotes that may be included in the original message:

First, many email senders will include quotes around the from name. These quotes around the name should likely be removed so that there are not two sets of quotes in from name in the forwarded message.
Second, there may be cases where there are quotes as part of the from name itself. These quotes should be preserved in the forwarded version.

vagifzeynalov commented 4 years ago

Hi @arithmetric,

Thanks for your response. Please feel free to close this PR or change it by yourself. Unfortunately I can't make any changes anymore. :)

Regards, Vagif

garychapman commented 3 years ago

This is quite an important one - we've been seeing emails to Yahoo/Ymail addresses sporadically bouncing for several months now, and it seems to happen when the (unquoted) Display Name is an email address whose domain doesn't match the address in angle brackets. We've started putting quotes around Display Name, all our our emails seem to be arriving.