reuse job count in $MAKEFLAGS if available

[milianw]

m...@milianw.de commented:

Which version of PhantomJS are you using? Tip: run 'phantomjs --version'.

current git master

What steps will reproduce the problem?

1. export MAKEFLAGS=-j40 (e.g. distributed compile farm)
2. ./build.sh # forgot to add "--jobs 40"

What is the expected output? What do you see instead?

The buildscript should see the "-j40" in my MAKEFLAGS env var and don't try to verwrite that. Instead only jobs according to /proc/cpuinfo on the local host are used, with an upper limit of 8

Which operating system are you using?

linux

Did you use binary PhantomJS or did you compile it from source?

compiled

Please provide any additional information below.

nfm

Disclaimer: This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #503. :star2:   2 people had starred this issue at the time of migration.

[ariya]

ariya.hi...@gmail.com commented:

Very good idea! Landed in https://github.com/ariya/phantomjs/commit/3a84eb6d16.

Thank you.

 
Metadata Updates

• Label(s) removed:
  • Type-Defect
• Label(s) added:
  • Type-Enhancement
  • Component-BuildSystem
• Milestone updated: Release1.6 (was: ---)
• Status updated: Fixed