ariya / phantomjs

Scriptable Headless Browser
http://phantomjs.org
BSD 3-Clause "New" or "Revised" License
29.45k stars 5.76k forks source link

1.9.6 release for the updated Ghost Driver 1.1 #11905

Closed ariya closed 10 years ago

ariya commented 10 years ago

This is to continue from 1.9.3 (see #11904). It will include Ghost Driver 1.1.

ariya commented 10 years ago

For the discussion on this release, see the mailing-list thread: https://groups.google.com/d/msg/phantomjs/ouFiiB1UoLw/-e26FmEcvY8J.

ariya commented 10 years ago

Adding @detro to the loop.

ariya commented 10 years ago

@JamesMGreene @Vitallium I don't have any Windows setup ready any time soon. Any of you can help producing Windows binary for this one (once I tag + release the source)? Thanks.

vitallium commented 10 years ago

Sure, I can do this. Any special instructions that should I know?

ariya commented 10 years ago

Nothing specific, mainly following the Windows part of http://phantomjs.org/release-preparation.html.

ariya commented 10 years ago

@Vitallium Try to do a dry run on the updated 1.9 branch and see if everything looks good to you.

vitallium commented 10 years ago

@ariya Looks good. Trying to build it.

Bazza74 commented 10 years ago

Is 1.9.6 available yet? I built it using the instructions on the build page but when I do phantomjs -v I get 1.9.2

Sorry if I've misunderstood something.

vitallium commented 10 years ago

@ariya Done. You can grab it here [SkyDrive] - http://sdrv.ms/KtouxJ

ariya commented 10 years ago

@MrLooke Most likely you didn't execute the binary you just built.

ariya commented 10 years ago

Thanks @Vitallium.

ariya commented 10 years ago

Announcement in the mailing-list: https://groups.google.com/d/msg/phantomjs/0GkXtTO6l4Q/n5jZcVlF0GEJ.

ghost commented 10 years ago

with the new phantomjs.exe i have an exception using the selenium .net web driver, it cannot find the 'cookiejar' module during the driver initialization. this is the stack trace

PhantomJS is launching GhostDriver... [INFO - 2014-01-21T13:39:00.512Z] GhostDriver - Main - running on port 9627 [ERROR - 2014-01-21T13:39:01.100Z] RouterReqHand - _handle.error - {"message":"C annot find module 'cookiejar'","line":289,"sourceId":42592680,"sourceURL":"phant omjs://bootstrap.js","stack":"Error: Cannot find module 'cookiejar'\n at phan tomjs://bootstrap.js:289\n at require (phantomjs://bootstrap.js:254)\n at :/ghostdriver/session.js:104\n at :/ghostdriver/request_handlers/session_mana ger_request_handler.js:75\n at :/ghostdriver/request_handlers/session_manager _request_handler.js:44\n at :/ghostdriver/request_handlers/router_request_han dler.js:70","stackArray":[{"sourceURL":"phantomjs://bootstrap.js","line":289},{" function":"require","sourceURL":"phantomjs://bootstrap.js","line":254},{"sourceU RL":":/ghostdriver/session.js","line":104},{"sourceURL":":/ghostdriver/request_h andlers/session_manager_request_handler.js","line":75},{"sourceURL":":/ghostdriv er/request_handlers/session_manager_request_handler.js","line":44},{"sourceURL": ":/ghostdriver/request_handlers/router_request_handler.js","line":70}]}

2014-01-21 14:39:01,212 [1] ERROR S3.Selenium.Program [(null)] - OpenQA.Selenium .WebDriverException: Unexpected error. Error - Cannot find module 'cookiejar' at OpenQA.Selenium.Remote.RemoteWebDriver.UnpackAndThrowOnError(Response erro rResponse) at OpenQA.Selenium.Remote.RemoteWebDriver.Execute(String driverCommandToExecu te, Dictionary`2 parameters) at OpenQA.Selenium.Remote.RemoteWebDriver.StartSession(ICapabilities desiredC apabilities) at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(ICommandExecutor commandExecu tor, ICapabilities desiredCapabilities) at OpenQA.Selenium.PhantomJS.PhantomJSDriver..ctor(PhantomJSDriverService ser vice, PhantomJSOptions options)

Bazza74 commented 10 years ago

^^ The same issue is with the python selenium web driver. Do you reckon it's a problem with phantomjs or the webdriver?

Teabeats commented 10 years ago

The linux 64 bit version of PhantomJS 1.9.6 is throwing the same exception when using the java Selenium driver.

vitallium commented 10 years ago

Could you please create a new issue? Thank you!

samlehman commented 10 years ago

How come brew install phantomjs doesn't get 1.9.6?

1.9.2 is the max that's on there.

ariya commented 10 years ago

@samlehman Let me play Captain Obvious here. The answer is because Homebrew has not updated its formula yet.

samlehman commented 10 years ago

@ariya Aye Aye Captain. Maybe how Homebrew works would be more obvious if it was taught in middle school or something.

Bazza74 commented 10 years ago

Created the new issue for the selenium problem: #11915