ariya / phantomjs

Scriptable Headless Browser
http://phantomjs.org
BSD 3-Clause "New" or "Revised" License
29.47k stars 5.76k forks source link

PhantomJS for Windows grew by 40mb in version 2.0 #13005

Closed mmanela closed 8 years ago

mmanela commented 9 years ago

This is less of a bug but more of a "make sure you are aware of this". The file size for PhantomJS 2.0 in the windows static build is about 40mb larger than the previous version. Is this expected?

I just want to make sure there wasn't some static compilation issue and that this increase is by design.

Thanks.

vitallium commented 9 years ago

Previous versions were compressed by UPX. But UXP can't process PhantomJS 2.0. There is a bug in UPX, so we're just waiting for a fix. (FYI: UPX can't process TLS properly)

mmanela commented 9 years ago

Ok that is good to know, thanks for the quick reply. I ship PhantomJS with my project and was concerned about quadrupling my download size.

Is there any ETA on when this fix may come?

ariya commented 9 years ago

I don't think you should rely much on PhantomJS executable size. If you are concerned about the size, your bundled PhantomJS with your project needs to be in a compressed archive (e.g. ZIP).

bpasero commented 9 years ago

+1 for small size, would like to update but this blocks

JamesMGreene commented 8 years ago

@Vitallium Do you have a UPX bug/issue link for this?

vitallium commented 8 years ago

@JamesMGreene it wasn't a UPX issue. It was on the Qt's side. Because when did the upgrade to Qt 5.2.1 (not sure about version), the issue just went off.

JamesMGreene commented 8 years ago

So should this issue be closed now, then?

vitallium commented 8 years ago

Yes!

JamesMGreene commented 8 years ago

:+1: