Don't try to ping if running on a DHT connection

arj03 / ssb-browser-core

ssb-server in a browser

Other

50 stars 8 forks source link

Don't try to ping if running on a DHT connection #46

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

If running on a DHT connection, don't try to do a tunnel ping, since that doesn't work and just causes errors.

arj03 commented 3 years ago

I don't really understand the error. Shouldn't DHT mean that you are connected directly to the remove peer? And in this case tunnel ping should be available. If not, then we might have a problem with the manifest.

KyleMaas commented 3 years ago

That could be. I don't understand how that ping call is dispatched. You're probably better suited to debugging that error.

arj03 commented 3 years ago

I'll have a look. I can reproduce the problem :)

KyleMaas commented 3 years ago

Perfect. Thanks!

arj03 commented 3 years ago

The problem was this

KyleMaas commented 3 years ago

Why is the room client getting involved in a direct DHT connection?

arj03 commented 3 years ago

The tunnel plugin comes from that.

KyleMaas commented 3 years ago

Ah. Gotcha.