search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Don't try to pull thread titles from ooo #116

Closed arj03 closed 3 years ago

arj03 commented 3 years ago

@KyleMaas I noticed that getting these messages ooo style in order to have the title show up properly was quite draining in the public view. So I'm inclined to just only to that for local messages.

KyleMaas commented 3 years ago

This would only really make a difference for when a thread root is posted by someone you're not following, correct?

KyleMaas commented 3 years ago

Otherwise it would always be local, because partial replication is only used for hops >1?

arj03 commented 3 years ago

We get full messages for the ones you are following and partial messages for what they are following. So it would only be messages outside this or older messages. I just noticed that it fired of maybe 20 ooo request and that seemed excessive.

KyleMaas commented 3 years ago

Not being familiar with how everything underneath this works, is there a way to batch those into one deferred request?

arj03 commented 3 years ago

Not right now. We might be adding that later.

KyleMaas commented 3 years ago

Main reason I added this is that "Replied to a thread" doesn't provide any context for replied messages, and it's hard to know which messages in the timeline can be mentally grouped into the same topic as you're reading them. Or to know if a message is part of a thread you've seen before, and therefor something to pay attention to. Although if you've seen it before, it would be local, so maybe that's not as much of a concern. I guess we could do this for now and look at reintroducing it when batched requests are supported.

arj03 commented 3 years ago

Exactly :)

KyleMaas commented 3 years ago

I will say at this point, having tried this, that nearly all of the messages in Public are now displaying as "a thread" with no context. Maybe this could be reintroduced as a preference, with the default off?

KyleMaas commented 3 years ago

Out of the first 20 replies (excluding thread roots) in my Public tab, 5 of them have "replied to" titles, and 15 are just listed as "a thread".

arj03 commented 3 years ago

That sounds a bit wierd. Is that on you new Kyle profile?

You should be getting the latest 25 messages of feeds followed by feeds you follow, so it sounds strange that you are missing to many. What I want to say it that this sounds more like a bug in that part.

The code that was removed had at least two problems: 1) it would just queue up messages so if you were offline for an extended amount of time you potentially had a lot of those 2) it doesn't store the ooo messages, meaning you download them every time you go to the public page. There really should be 2 ooo methods (peek and get + store).

I would go looking for why you are missing so many messages first of all.