Profile image placeholders on private

KyleMaas commented 3 years ago

Centralize "blank profile" image into helpers so it can be reused in multiple places without inline builds adding multiple copies of it.
Add "blank profile" image to Private tab's Recipients list for people who don't have a profile image.
Sort Recipients suggestions by name.
Don't wipe out the people list in suggestions if no matches are found, also making it consistent with how recipientsOpen() works.
Only update the component's people list once per method instead of modifying it (and possibly triggering hooks/processing) every time an element is pushed onto the array.
Clean up a few stray tabs.

Fixes #131.

arj03 commented 3 years ago

This looks good. I'll just note that ssb-suggest does sort the results so that the most relevant are supposed to be first.

KyleMaas commented 3 years ago

Ah, okay. I did that because when you go to Private, start a new message, and click into the Recipients box to pop it open, they looked like they were in semi-random order.

arj03 commented 3 years ago

Yeah, it is a bit confusing

arj03 commented 3 years ago

Think it's good as you did it

KyleMaas commented 3 years ago

Sounds good.

arj03 / ssb-browser-demo

Profile image placeholders on private #133