search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Suggestions for profiles and channels #147

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

This adds an extensible architecture for auto-suggesting things while the user is typing, such as profiles, channels, or (in the future) blobs.

One note on this - there is an issue where if it pops up the suggestion box and you then navigate your cursor away from where you're typing, it has no way to track that and the suggestion box stays open. This is, unfortunately, not something I think we can fix, since we would need some kind of an event to be emitted by the TUI editor when the cursor moves. It works without it, but just be aware that that behavior is likely not something we can fix right now. I've reported it upstream as https://github.com/nhn/tui.editor/issues/1370

Fixes #129.

arj03 commented 3 years ago

Looks good, had that thing about channels I we need to fix first. But otherwise good to go.

arj03 commented 3 years ago

Also added you to this repo so it's easier to keep you branches here.

KyleMaas commented 3 years ago

Joined the repo. Thanks!

KyleMaas commented 3 years ago

How would you go about putting together an index of channels? I'd like to use that in #189 as well.

arj03 commented 3 years ago

For searching it would be really nice with this prefix like index search. So you type tel and get all the channels that starts with tel. I don't have time right now to go into the details of implementing it. Also this is probably a bit lower priority because its mainly for channel searching in the search box.

KyleMaas commented 3 years ago

How about this? https://github.com/arj03/ssb-browser-core/pull/23

KyleMaas commented 3 years ago

If we do it with an index like this, we can use it for both suggestions (in the Markdown editor and the search box) as well as for the Channels tab.

KyleMaas commented 3 years ago

This one's obsolete with the new channel index stuff. Closing.