search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Show thread participants blocking you when you reply #222

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

When replying to a thread, show which participants in the thread are blocking you and will not see your reply.

Gotta be honest, I couldn't really test this one. I tried various combinations of simulating being blocked, but I didn't have a great data set to be able to confirm that I could see a thread with someone who was blocking me and that this would show that. I'm hoping this can be tested, but at this point I'm not sure either one of us are actually controversial enough with our posts to be blocked by someone where we would otherwise see their posts.

Fixes #205.

arj03 commented 3 years ago

Before I review this, one small requst, can you upgrade your npm version so we don't get giant diffs on the shrinkwrap file? :)

KyleMaas commented 3 years ago

I'm running the latest "non-beta" version of it that Gentoo provides. I guess I can try running their "beta" version.

arj03 commented 3 years ago

npm should ask you to upgrade. Or try npm i -g npm to get version 7.

KyleMaas commented 3 years ago

That has the potential of messing with system packages. I try not to global install any npm packages for that reason. Trying recompiling with Node.js 15.8.0 and the version of npm that goes along with it.

KyleMaas commented 3 years ago

How's that look?

arj03 commented 3 years ago

The problem was a lot of changes for the shrinkwrap files, lets see the next time you change something in package.json :)

KyleMaas commented 3 years ago

By the way, I'm going to be quite busy today and won't be able to do much. So if this needs changes, by all means please feel free to make them. I had to develop this blind since I didn't have a good test data set, so it's probably going to be better for someone else to put the finishing touches on it.

Also, I'm running out of feature requests and bug reports I feel like I can actually tackle. Do you have anything else you'd like to see built that you could file issues for?

arj03 commented 3 years ago

No worries. There is no rush with these things. I'll create a few issue with some nice to have things.

arj03 commented 3 years ago

I'm most interested in getting this as stable as possible rather than adding a bunch of feature. So stuff like make it work with multiple tabs would be really nice

KyleMaas commented 3 years ago

Oh, I agree. It's just that, try as I might, the majority of the bugs I've found lately seem to be above my competency level to be able to debug. :)

Too many of them turn out to be so deep within dependencies that I have a hard time keeping track of it all. And I don't have the deep intimate knowledge of everything in the dependency tree that I'd need to feel really comfortable with some of the core debugging I've attempted to do. I may get there eventually, but for now, I seem to be having far more success with things closer to the surface. For example, my efforts to try to debug the out-of-order sequence stuff the other day. I can gather data, but I don't even know where all that comes from, and a lot of it is in asynchronous callbacks or event handlers with no stack trace to help me. So for stuff like that, gathering data is about as much as I can do due to lack of understanding.

Plus, @arj03, it helps that you actually respond in a timely manner when I ask questions and actively critique my contributions rather than let them languish with nothing but radio silence for what's going on. Not all of the dependencies where I've found bugs have quite as active of maintainers. Makes it a lot easier to work on when you don't have to wait several weeks (and forget what you were doing) before you hear a response. Heck, I'd much rather have a "this code is terrible, and so are you, and so's your dog" response than just nothing. At least that I can work on. :)