search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Show profile changes #230

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

When someone has updated their profile, show what they changed.

Fixes #229.

arj03 commented 3 years ago

I think this needs to test if its a self update or not. Or least it should show what you are updating. Also this seems to display very old entries? Like try going to my main profile. Anyway minor things, looking good otherwise :)

KyleMaas commented 3 years ago

Self update works just fine here. It displays it as "You posted a profile update". Maybe I'm not understanding the issues you're having.

I'm not seeing any issues looking at your main profile. I actually don't see any profile changes in the recent messages area for you, only follow changes (I'm running the branch that has both this and the follow/unfollow stuff). What are you seeing?

KyleMaas commented 3 years ago

I have noticed some weirdness with db2 lately. Like for certain queries I'm getting duplicates of results. But I haven't been able to nail down a good test case or way to duplicate it, so I haven't reported it because I don't know if it's actually in db2 or if somehow replication is stuffing duplicates into the database. Perhaps that's related to what you're seeing?

arj03 commented 3 years ago

I think I know what the cause of the duplicates are.

arj03 commented 3 years ago

What i mean with self update is that if you do an about of something other than yourself it is also shown. Maybe it should only be the ones you assign to your own feed. We don't show the others anyway.

KyleMaas commented 3 years ago

Ah, okay. I'll see what I can do.

KyleMaas commented 3 years ago

Something like that?

KyleMaas commented 3 years ago

As long as you're around, is there anything else about this that needs to change?

arj03 commented 3 years ago

I was just about to look at this one

arj03 commented 3 years ago

I'm considering only showing this on profile page. What do you think?

KyleMaas commented 3 years ago

I put it onto the Public tab as well due to Queen of England changing names and profile pictures and confusing the heck out of everyone. Figured it'd be good to show that kind of information for all users, not just the one specific user you've already selected, because otherwise that kind of a change wouldn't become obvious.

arj03 commented 3 years ago

Good point. Lets leave in the public.

arj03 commented 3 years ago

Thanks :)