search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

invalid message: expected sequence 2 but got:1 #234

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

Figured I might as well file an issue for this so we can collect together information about it. I'm getting this fairly consistently now in a lot of different situations and I don't understand enough about what it's doing to be able to track it down.

Steps to reproduce:

  1. Start a new profile (open it in a private browser window or something).
  2. Leave everything in the onboarding screen as defaults and click Get Started.

That's all it takes for me to trigger that error.

KyleMaas commented 3 years ago

Also, can you give me any pointers as to where to start debugging this?

arj03 commented 3 years ago

The error is from validate. So either here or here. It must be somehow related to how ssb-browser-core does the partial replication.

KyleMaas commented 3 years ago

How long do you think until https://github.com/ssb-ngi-pointer/ssb-subset-replication is usable?

arj03 commented 3 years ago

We are aiming for May

KyleMaas commented 3 years ago

Okay. So probably worth hunting this down, then.

KyleMaas commented 3 years ago

@arj03 Probably could use your help on this one, too. Having a hard time making any progress at all on this.

arj03 commented 3 years ago

Nice find. I can reproduce this problem.

arj03 commented 3 years ago

Fixed with this commit

KyleMaas commented 3 years ago

Hokey smokes! That's all it took? The difference it makes to have the knowledge of how it all works...

I'll give it a test here in a few minutes.

arj03 commented 3 years ago

Yeah, a bit of a funny bug. Very nice to have it fixed though, might have caused other kinds of wierd problems.

arj03 commented 3 years ago

I'll close this. I made a release with these changes :-)

KyleMaas commented 3 years ago

Sounds good. Just finished doing a write-up on one-way follows.

Yep, looks like that fixed it. Thanks!

arj03 commented 3 years ago

Sweet! Thanks for reporting this.