arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Dedupe more libraries #240

Open KyleMaas opened 3 years ago

KyleMaas commented 3 years ago

Other libraries we use multiple copies of:

I'd keep going, but I'm finding a lot more. Let me see what I can do to fix some of these. Some of them are minor version changes that shouldn't make a lick of difference.

Filed issues on this subject:

arj03 commented 3 years ago

I think if you create PRs like for the ssb-keys-mnemonic we should be able to get them merged. The pull* modules might be a bigger problem as they are not actively maintained sadly. The flume stuff shoul not be used. Might be pulled in like in friends but shouldn't be used.

KyleMaas commented 3 years ago

flumecodec is pulled in by ssb-friends (via flumeview-reduce) and atomic-file, both dependencies of ssb-browser-core.

arj03 commented 3 years ago

Right, this reminds me, we need to remove the atomic-file dependency in ssb-browser-core in favor of atomically-universal. Is that something you are up for?

arj03 commented 3 years ago

https://github.com/arj03/ssb-browser-core/issues/10

KyleMaas commented 3 years ago

~https://github.com/staltz/ssb-keys-mnemonic/pull/3~

KyleMaas commented 3 years ago

~https://github.com/ssbc/ssb-friends/issues/56~

KyleMaas commented 3 years ago

~https://github.com/arj03/ssb-browser-core/pull/29~

KyleMaas commented 3 years ago

https://github.com/dominictarr/sodium-browserify-tweetnacl/issues/3

https://github.com/dominictarr/sodium-browserify-tweetnacl/issues/4

KyleMaas commented 3 years ago

See ~#244~ for a patch for some of these.

KyleMaas commented 3 years ago

I think I've done about everything I can to fix this locally. I'm going to leave this open to show progress on dependencies, but for now, I don't think there's much more we can do here.