search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Thread view shows messages outside of follow graph no matter their type #251

Open KyleMaas opened 3 years ago

KyleMaas commented 3 years ago

Thread view does not filter messages based on type, which means messages may be shown as outside of follow graph even if we don't know their type (whether they're posts or not) or are private.

arj03 commented 3 years ago

Right, that should be relatively easy to fix though

KyleMaas commented 3 years ago

Yep. Just didn't want to forget about it.

KyleMaas commented 3 years ago

Actually, this might not be so simple. Messages outside of the follow graph are known about only by their IDs by being mentioned in other messages. Which means without fetching them, we can't get their type. So...I'm not sure this is actually possible to fix.

arj03 commented 3 years ago

Right, but we can implement some kind of warning system for that, and maybe a small cache so that you don't have to fetch the messages again. This would be very important for blocked users.

KyleMaas commented 3 years ago

I think I'm going to be a bit out of my league on that - mind taking this one?

arj03 commented 3 years ago

Sure, a bit busy now but I'll try keeping this in mind

KyleMaas commented 3 years ago

Yeah, no problem. Just trying to go through old bugs and see which ones are still valid.