Closed KyleMaas closed 3 years ago
This is really exciting! I'll be in a call with mix soon so don't have time to properly review this, and it needs because it's a quite big change. Is it ok if I create a branch with some changes while I review it? Have some ideas to make this a bit simpler maybe. Also if you create your branches in this repo instead of KyleMass, then it should be easier to have that kind of workflow.
Go for it. This should allow you to make changes, though - I left that on.
If you do make changes, there are a few important things about this:
Also, if you can commit early and often, that'd be great, because my next step is to work on getting center clicks and context menus programmatically opening child windows so they can be tied in. I plan on doing the same. Don't need any more conflicts than necessary.
Moved to #260.
Basic protection against concurrency issues. See #139. Uses a localStorage-based mutex which times out in case a tab dies on us. Adds a bunch of extra checks throughout the codebase to try to gracefully handle a locked SSB.
Also fixes: