search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Add pt-BR translations #286

Closed luandro closed 3 years ago

luandro commented 3 years ago

Add translations to pt-BR.

arj03 commented 3 years ago

Great! You marked this as a draft, I don't see a problem merging this right away unless you want to revise it more?

I havn't used translation very much, @KyleMaas did all of the work on enabling it. How is the coverage, do we need more strings translated?

KyleMaas commented 3 years ago

Excellent! I'm glad to see someone using this functionality.

KyleMaas commented 3 years ago

I love what you've done here, but now I'm going to be greedy and ask: Would you feel comfortable doing a European Portuguese translation as well? Just so we have a little better coverage of the base "pt" space like how we have a base "en" translation as well as "en-UK". Even if it's not perfect, you'd have a much better shot at getting it close than either @arj03 or I.

Heck, for that matter, you'd probably have a better shot at the other Romance languages than either of us. If you want to try and tackle one of those, that'd be awesome. Again, even if you just get close, it's better than we'd be able to do. The Japanese translation is mostly machine-translated with corrections based on my very limited knowledge of Japanese (my proficiency in everyday Japanese is not great, but my technical Japanese proficiency is nearly non-existent without help, hence the machine translation base).

KyleMaas commented 3 years ago

If not, I still have no problems merging this. I just figured I'd be greedy and ask. :)

luandro commented 3 years ago

@KyleMaas I have no idea what's the difference between Brazilian and European Portuguese. We can just copy this and use it as pt until someone from Portugal may want to correct it. I can also help translating to Spanish. I built this json-translator for machine translation.

I'm still waiting for some peers to review to remove draft status.

KyleMaas commented 3 years ago

@luandro Sounds good. Translator utility looks quite handy. Thanks!

luandro commented 3 years ago

@henrique2Zs thank you very much! Please continue as you like.

luandro commented 3 years ago

Should be good to go!

arj03 commented 3 years ago

Sweet, thanks! :heart: