search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Show loading message #296

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

Show a loading message when waiting for results from a message search on the Thread and Threads pages.

Fixes #292

arj03 commented 3 years ago

This looks good. Let me test it before merging. Btw great to see you back :)

I'm currently testing a greater refactor of connection and replication handling https://github.com/arj03/ssb-browser-core/pull/52. I'll post a PR to ssb-browser-demo a bit later today. Are you up for helping to testing that? :)

KyleMaas commented 3 years ago

Good to be back. Like I said a few months ago, my free time tends to come and go. So I try to pack as much into my free time as I can.

Sure, I'd be up for helping with testing. I've been watching the comments on the refactors and it looks like a lot's been going on, but I haven't kept up with what exactly you've been working on. And "Unbermuda" doesn't help much with explaining what the goals are. What all needs to be tested, and is it ready to test now or are you still working on it?

EDIT (Typo)

arj03 commented 3 years ago

Unbermuda refers to the holy trinity of ssb-replicate, ssb-friends and ssb-ebt. Before they were all tied together, one calling another, sometimes overwriting methods etc. It was a total mess. So we jokingly referred to this as the bermuda triangle, the place people go and never come back. Staltz did a great job of untangling all of this so that friends and ebt only does 1 thing. Replicate is not used anymore. Instead things are orchestrated through a small module. I had to change this a bit to work in browser-core for partial replication. This is step 1 of enabling proper partial replication.

This branch should allow you to test: https://github.com/arj03/ssb-browser-demo/pull/297

arj03 commented 3 years ago

Thanks, this seems to be working :)