Update ToastUI-Vue editor 3.0.0

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser

Other

58 stars 11 forks source link

Update ToastUI-Vue editor 3.0.0 #299

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

This partially works. Problems so far include:

~Clicking a suggestion in a popup suggestion box (like for channels or people) does not work on the first try. Subsequent suggestion clicks do seem to work.~
~Adding images does not work properly.~

Fixes #298

arj03 commented 3 years ago

Great first pass there. I tried checking out this branch and building, it's 150kb smaller. And that is not including the css file one doesn't need to include.

KyleMaas commented 3 years ago

That pretty much works. Found an interesting bug I need to file, but it's unrelated to this. Think I'm going to take this out of Draft status now. Make sure you test this well before merging, though - the underlying editor is considerably different, so I'm not confident I've handled all edge cases.

KyleMaas commented 3 years ago

Inlined size before: 7,831,765 bytes

Inlined size after: 12,193,483 bytes

Something weird going on...

KyleMaas commented 3 years ago

Not sure what's going on with inlining. I'm not seeing much (if any) difference between release build sizes between the master branch and this one. So if you're good with how this works, go for it, and I'll try and troubleshoot inlining later.

arj03 commented 3 years ago

Btw one of the audit errors is from the inline tool.

arj03 commented 3 years ago

I'm testing this now, seems to be working, will fix #300 before merging.

arj03 commented 3 years ago

This looks really good. Thanks for taken on this. The js reduction is quite substantial. The css is a bit bigger, but not anything close to the increase you are seeing in the inline tool.

KyleMaas commented 3 years ago

For whatever reason, this merge is messing up pulling master.

arj03 commented 3 years ago

What, that's strange. Works fine here. Sure you are on master? :)

KyleMaas commented 3 years ago

Yep. Don't know what's going on, but something's goofed up badly. Wiping and re-cloning to see if that works.

KyleMaas commented 3 years ago

Not sure what happened but wiping and reloading seems to have fixed it.