search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Minor things with new toast ui #303

Closed arj03 closed 3 years ago

arj03 commented 3 years ago

There is a small css error on profile page in the input field. The header is too large for the input. @KyleMaas

I also has this error in console: this.editor.remove is not a function. That problem seems to be fixed on master, but sadly no new release.

KyleMaas commented 3 years ago

Can you show me a screenshot? It looks fine here.

Also, where are you seeing the remove error?

arj03 commented 3 years ago

The error was in the console. Ah, the profile is only showing the problem if the console is filling 50% of the screen. With that closes it work fine.

KyleMaas commented 3 years ago

What triggered the console error, though? I grepped through the codebase and couldn't find a line that said this.editor.remove.

arj03 commented 3 years ago

This one https://github.com/nhn/tui.editor/commit/999b9e22750ed64302a2880fce2e1fbcb99ba250

KyleMaas commented 3 years ago

Ah, so it's an upstream problem. Gotcha.