search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

profile editor too big #313

Open arj03 opened 3 years ago

arj03 commented 3 years ago

image

manage to capture this one now @KyleMaas. It happened when I started a new private chrome session, did manual and just navigated to the new profile.

KyleMaas commented 3 years ago

Ah. Okay...that's going to be an interesting one to try to track down.

KyleMaas commented 3 years ago

This one may or may not be worth fixing right now - looks like they're having other problems with things exceeding the bounds of the editor. See:

https://github.com/nhn/tui.editor/issues/1633

https://github.com/nhn/tui.editor/issues/1627

KyleMaas commented 3 years ago

As far as I can tell, we would need to call classifyToolbarItems somehow:

https://github.com/nhn/tui.editor/blob/3983510e871bf4cfdd98131a45e447d8cad1fd86/apps/editor/src/ui/components/toolbar/toolbar.ts#L192

There are several things that call that, but I think considering it looks like they're going to have to do some work on overflow anyway that it's probably not worth adding a hacky solution that'll likely break in a newer version.

arj03 commented 3 years ago

Agree, lets wait and see.