search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Add mnemonic key recovery to onboarding #316

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

Allow the user to choose to onboard as a new user or go straight to loading from a mnemonic key.

Fixes #255

KyleMaas commented 3 years ago

I'll note that I filed this bug due to a quirk I had to work around to get this to work:

https://github.com/egoist/vue-slim-tabs/issues/141

KyleMaas commented 3 years ago

It works properly now. But it did take some trial and error to work around that bug. At least the bug was consistent so I could. :)

arj03 commented 3 years ago

This is great, can't count how many times I have needed something like this :) I'll let this simmer a day or two and see if upstream responds to your issue.

KyleMaas commented 3 years ago

Thanks! I already worked around that issue, so it shouldn't affect this. It was just a long road finding what exactly triggered it. In this case, it happened if I put anything after the <textarea> on the second tab. If I did, then you could switch to that tab but couldn't switch back. So I just moved the WARNING and NOTE messages outside of the tab area, and now everything's hunky dory. But it is a bug to be aware of if you ever try to add anything to that tab.

(I did look at other tab libraries. But this one seemed to be about the simplest, most stable, and smallest I could find. So working around the bug seemed to be worth it.)

arj03 commented 3 years ago

Great work! I just tested this and work perfectly.

KyleMaas commented 3 years ago

Awesome. Thanks!