search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Unchecking filter checkboxes does not take the filter off #55

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

After the latest filter changes, if you:

  1. Go to the Public tab.
  2. Check a filter box. Observe that the filter takes effect and shows only matching posts.
  3. Uncheck the filter box.

Expected result: Filter is removed and everything goes back to displaying as if the filter was not applied.

Actual result: Filter stays applied until the Public tab is reloaded, either by refreshing the page or navigating away from Public and back again (for example, clicking Private and then Public).

KyleMaas commented 3 years ago

Ah, I think I figured it out. this.onlyDirectFollow was being accessed outside of scope. Should have a pull request soon.

KyleMaas commented 3 years ago

56 fixes this.