search

arj03 / ssb-browser-demo

A secure scuttlebutt client interface running in the browser
Other
58 stars 11 forks source link

Thread/post titles #67

Closed KyleMaas closed 3 years ago

KyleMaas commented 3 years ago

As I understand it, there is at least one SSB client which allows you to add titles to posts which are stored in an attribute somewhere in the post data (don't know if it's a root-level attribute or under content or something). I don't believe this is in the standard for the protocol.

However, one way or another, it would be nice if at least threads either showed a title from the root post (if it's available) or tried their best to generate one based on the root post's content. This could ideally be used for both the title of the Thread view as well as in the "replied to" links within individual posts everywhere else.

KyleMaas commented 3 years ago

So it looks like this is where that title comes from:

https://github.com/ssbc/patchwork/blob/master/lib/depject/message/async/name.js

KyleMaas commented 3 years ago

I'm not sure I'd consider #93 to be a full fix of this just yet. Thinking if we're going to show them, we should probably also support posting them, with a warning to the user that not all clients support it.

KyleMaas commented 3 years ago

I think between #93, #95, and #96 we could probably call this one fixed.

arj03 commented 3 years ago

Yes :)