arjan / decorator

Function decorators for Elixir
MIT License
385 stars 20 forks source link

Empty body decorate #24

Closed ludwikbukowski closed 6 years ago

ludwikbukowski commented 6 years ago

This PR will work once those will be merged:

IT resolves the issue from: https://github.com/arjan/decorator/issues/18

arjan commented 6 years ago

I merged #20 and #22, thanks for that. Is this PR still relevant? I've pushed out release 1.2.4 as well.

arjan commented 6 years ago

Oh wait I see this is a different issue, can you resolve the conflicts?

ludwikbukowski commented 6 years ago

@arjan There is some issue related to old Elixir version 1.3

arjan commented 6 years ago

Strange, does not seem too bad to me. I'm open for increasing the minimum Elixir version for next release, can you try that? e.g. to 1.5

ludwikbukowski commented 6 years ago

Im just going to create a new PR because this PR was based on my already customised branch and commits history is getting messy

ludwikbukowski commented 6 years ago

https://github.com/arjan/decorator/pull/27