WiFi setup: NTP server is not saved

arjenhiemstra / ithowifi

Itho wifi add-on module (ESP32 wifi to itho I2C protocol)

GNU General Public License v3.0

181 stars 32 forks source link

WiFi setup: NTP server is not saved #104

Closed vandenberghev closed 2 years ago

vandenberghev commented 2 years ago

On the WiFi Setup page, when I enter another NTP server and hit save, the setting is not retained but the original pool.ntp.org seems to be restored. Editing the json on the file system directly does work.

Device information

Firmware version 2.4.0-beta1
Hardware revision CVE rev. 2
CC1101 RF module enabled [ yes ]

arjenhiemstra commented 2 years ago

Thanks for spotting this! https://github.com/arjenhiemstra/ithowifi/blob/884c97b463dfa2cd9fd5835b3d8408b6efdd5ecc/software/NRG_itho_wifi/src/webroot_source/controls_js_sources/javascript.js#L266 nptserver != ntpserver ;-) Will be corrected in the next version.

arjenhiemstra commented 2 years ago

Fixed with https://github.com/arjenhiemstra/ithowifi/releases/tag/Version-2.4.0