arjenhiemstra / ithowifi

Itho wifi add-on module (ESP32 wifi to itho I2C protocol)
GNU General Public License v3.0
181 stars 32 forks source link

Cannot switch off AP mode #233

Closed vharten closed 7 months ago

vharten commented 7 months ago

Describe the bug After firmware upgrade to 2.7.2, AP mode suddenly went on. I try to switch it off by setting the AP timeout to zero, but it remains in Active state, even after a reboot.

To Reproduce Happens always.

Expected behaviour AP mode switched off after setting AP timeout to zero

Screenshots image

Device information

Desktop (please complete the following information):

arjenhiemstra commented 7 months ago

Thanks for spotting this! I found the issue: https://github.com/arjenhiemstra/ithowifi/blob/7fa822487636c403f4896e97c7f00b88a85b61ea/software/NRG_itho_wifi/main/tasks/task_syscontrol.cpp#L553-L558

The order is wrong here. setupWiFigeneric call should be after config load... This was apparently masked by an immediate shutdown of the AP code somewhere else in the code but that is not triggered anymore in 2.7.2 due to some other changes.

I'll fix the issue and release 2.7.3 probably later today.