search

arjenhiemstra / ithowifi

Itho wifi add-on module (ESP32 wifi to itho I2C protocol)
GNU General Public License v3.0
176 stars 30 forks source link

Wiki says WPU heat pump is experimental #264

Closed ovitters closed 1 month ago

ovitters commented 1 month ago

Describe the bug The wiki page https://github.com/arjenhiemstra/ithowifi/wiki/Itho-WPU-Heat-pump-support has the following:

Requirements [..] Latest firmware for add-on here and look for most recent firmware. Do not rely yet on the built-in updater as the WPU firmware is still experimental and not officially released

The WPU support is part of the firmware for a while, no?

To Reproduce Steps to reproduce the behaviour:

  1. Go to the above mentioned wiki page and read the requirements

Expected behaviour The requirements on the wiki to specify the minimum required firmware version. Plus maybe a warning regarding the hardware firmware version?

I wasn't certain which firmware of the addon added the support, else I would've fixed the wiki myself. I'm completely willing to fix the wiki if I knew the correct info.

arjenhiemstra commented 1 month ago

First off all very much thanks for spotting this and taking the effort to report this ofcourse! Since you have an GitHub account, you are able to edit the wiki information yourself. That's how basically all content on the wiki came into existence, community input. So if you are willing to edit the info directly, that would be very much appreciated!

Edit: I'm on holiday and reading half headed apparently...

"I wasn't certain which firmware of the addon added the support, else I would've fixed the wiki myself. I'm completely willing to fix the wiki if I knew the correct info."

Didn't read this careful enough. But to be honest, I do not know either anymore. The wiki is not versioned on firmware versions and just represents the most actual info with the latest firmware version (or it should in most circumstances). So feel free to edit it as you like!

ovitters commented 1 month ago

The wiki is not versioned on firmware versions and just represents the most actual info with the latest firmware version (or it should in most circumstances). So feel free to edit it as you like!

Ah, good to know! I've edited it with that in mind!

PS: Please don't read github on your holiday!

arjenhiemstra commented 1 month ago

Much appreciated!!

And you are right, I'll try to improve on that 😇