search

arjunattam / vscode-chat

Chat with your team while you collaborate over code using VS Live Share
https://marketplace.visualstudio.com/items?itemName=karigari.chat
GNU General Public License v3.0
529 stars 67 forks source link

[vscode] [discord] Invalid token #252

Open JohnnyWoong opened 5 years ago

JohnnyWoong commented 5 years ago
arjunattam commented 5 years ago

Hey @JohnnyWoong, thanks for reporting this. Could you share more info on how this happened? The token mechanism as detailed in the doc should work - please let me know if there's anything missing in the doc

Doc link: https://github.com/karigari/vscode-chat/blob/master/docs/DISCORD.md

lukaskleinhaneveld commented 5 years ago

Hey, I get this too. For me it happens when I change workspace. Everything just blanks out, no more PM's or Unreads etc. Hope this helps a little

arjunattam commented 5 years ago

Thanks @lukaskleinhaneveld. Just to be sure I get this properly: does the token work for some workspaces?

Also, are you behind a network proxy by any chance?

lukaskleinhaneveld commented 5 years ago

I'm at work to be honest, just started there so I wouldn't know haha. I think the token might turn invalid on changing workspaces/servers. I'll check!

arjunattam commented 5 years ago

Sure, let me know. in case you are behind a network proxy, you will have to set some config as given here: https://github.com/karigari/vscode-chat/blob/master/docs/CONFIG.md

lukaskleinhaneveld commented 5 years ago

Sure, will do!

lukaskleinhaneveld commented 5 years ago

Oh, I forgot to mention. When I change servers in Discord in VS Code, I also get signed out of my Discord client.

arjunattam commented 5 years ago

oh, that is interesting. let me investigate this

lukaskleinhaneveld commented 5 years ago

I just found out that when you've opend a "Wordspace" you can access all of the channels (including voice chat) in that specific workspace. Also PM's and groups and unreads. As soon as I hit [CTRL] + [Shift] + [P] and type "Chat: Change Workspace" the token goes invalid and the extention "Crashes". But now when I check my already opened Discord client, I can still click on other channels, but the messages don't load anymore. Sometimes it even logs me out of the client entirely

lukaskleinhaneveld commented 5 years ago

Yeah, so I just had to restart my Discord Client and had to login again. So I guess it DOES log you out on the back-end. This only gets updated on restart I suppose

lukaskleinhaneveld commented 5 years ago

[CTRL] + [Shift] + [P] -> "Chat: Change Channel" DOES work however, but only within the selected Workspace and PM's

arjunattam commented 5 years ago

Thanks for sharing this. Hmm I'm not able to repro the case where my discord client is logging out. Is this happening on all workspaces or some in particular?

Also, it might help to see more logs. Can you run the "Toggle Developer Tools" command on vscode and see if that shows anything?

lukaskleinhaneveld commented 5 years ago

Ah this gives me some more info. I also noticed when clicking on locked channels I get an error. See attachments. I've also added the extended error info when changing workspaces

error when clicking locked channel: error when clicking locked channel

error when switching workspaces: error when switching workspaces