search

arjunmat / slack-chat

A support chat feature for your website that integrates with #Slack
GNU General Public License v3.0
137 stars 37 forks source link

Add the ability to show user real name #9

Closed agarzola closed 8 years ago

agarzola commented 8 years ago

This rebases @jpros’ PR #1 onto the current master branch. No test suite to speak of, so I haven’t tested this. I just rebased, fixed the one conflict, and declared userList at the top of the closure to ensure it stays out of global scope.

agarzola commented 8 years ago

From your response to @jpros’ PR:

Also, can you add an option to use user image instead of support image.

Could you please clarify? As I understand jpros’ code, it takes a support staff user’s profile image from the Slack message and uses that instead of a default image. I think that’s what you’re asking, but I’m not clear.

I’m interested in using this script on a small, single-client project, so I’d be happy to contribute further if it’ll help me get functionality I’m looking for. jpros’ pull request seems to add the functionality I’m looking for, which is why I’m trying to get it merged. Thanks for putting this out there!