Closed cdressing closed 2 years ago
Merging #130 (4937d22) into main (57980b6) will decrease coverage by
0.38%
. The diff coverage is69.44%
.
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 74.22% 73.84% -0.38%
==========================================
Files 22 22
Lines 1920 1953 +33
==========================================
+ Hits 1425 1442 +17
- Misses 495 511 +16
Impacted Files | Coverage Δ | |
---|---|---|
src/simmer/drivers.py | 87.80% <ø> (ø) |
|
src/simmer/sky.py | 75.71% <33.33%> (-1.90%) |
:arrow_down: |
src/simmer/insts.py | 82.41% <66.67%> (-0.61%) |
:arrow_down: |
src/simmer/image.py | 80.23% <68.75%> (-3.10%) |
:arrow_down: |
src/simmer/registration.py | 78.31% <78.57%> (-1.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 57980b6...4937d22. Read the comment docs.
Description
Corrects issue writing lists of dark frames to the config file when multiple sets of darks were obtained at the same exposure time. Previously, the code got confused if dark exposure times were repeated and separated by other files.
drivers.py used to re-run the drivers for darks, skies, and flats after registration. Now the code doesn't repeat those steps.
Improved validate_config.py so that "sky flats", "dome flats", "flat", and "flats" are all treated as matches to "flat" in the .csv file. Also made formatting of J+Ch4-1.2 matches more flexible.
Added /verbose keyword to validate_config.py so that the code can be run more quietly.
Now reads both filters in FITS headers to correctly handle J+Ch4-1.2 files. Previously, those were incorrectly grouped with J images.
Motivation and Context
Improves functionality of validate_config.py and corrects a bug in adding darks to config file. Now fixes bug #134 .
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: