Migrate to new csproj SDK

ark-mod / ArkSavegameToolkitNet

Library for reading ARK Survival Evolved savegame files using C#.

MIT License

21 stars 27 forks source link

Migrate to new csproj SDK #13

Closed brcaswell closed 4 years ago

brcaswell commented 4 years ago

this branch introduces changes to migrate csproj files of this repo to the new csproj (except testconsoleapp)

remove nuget package files and assembly files;
ensure InternalVisibleTo AssemblyAttribute is set in dependency project
update Newtonsoft package references to 12.0.2;
remove unnecessary proj reference in test console app (should only reference to ArkSavegameToolkit.Domain proj - the would-be package)
Adds the NuGet Symbol file git ignore rule to the root .gitignore file

brcaswell commented 4 years ago

Showing results of TestConsoleApp test after migration.

Note: A new branch and changes will be based on these changes (and follow up this branch) to further handle the NuGet packaging and publishing supported by project build events.

these changes follow a post merged commit review \ comment I prompted on @mxtsdev ...

mxtsdev commented 4 years ago

Hey,

I've already put some work into porting the toolkit to .NET Core 3.1. It includes migrating the project to use the new csproj-format. This is what we are going for in the future. You can check the code here: https://github.com/mxtsdev/ArkSavegameToolkitNet/tree/netcore

If you are interested in retaining support for .NET 4.6.1 I welcome any help to make those changes on that branch and to open a pull request for it (i.e. add multi-targeting).

As it stands I'm not sure what to do with this because the .NET Core branch is what we are moving forward with and it is already csproj, but has no support for .NET 4.6.1.

brcaswell commented 4 years ago

I am going to close this PR.

I might contribute changes to that branch you're referencing.