The dinos stats that are higher than 127 are going back to -128.

ark-mod / ArkSavegameToolkitNet

Library for reading ARK Survival Evolved savegame files using C#.

MIT License

21 stars 27 forks source link

The dinos stats that are higher than 127 are going back to -128. #7

Open flagoss opened 6 years ago

flagoss commented 6 years ago

The dinos stats that are higher than 127 are going back to -128. Happen on servers with a max wild level of 400-500 or more.

I already fixed that issue on my fork https://github.com/flagoss/ArkSavegameToolkitNet/commit/17cff5654e8e228af2e5c4ee381f36c571115671 Its only changing some variables type from sbyte to byte.

ghost commented 6 years ago

Okay ... I'll get those merged in tomorrow.

flagoss commented 6 years ago

Did you have the time to look at it ?

flagoss commented 5 years ago

Do you think you could merge these changes? I have running with those for the past 3-4 months without a probleme.

ghost commented 5 years ago

sheesh i missed this in the last update. okay i have an update coming this weekend anyway. I'll do it then.

flagoss commented 5 years ago

Great. Thank you very much.

brcaswell commented 4 years ago

@flagoss can you review this PR that mentions this issue (I could not reference you directly as a request reviewer)

Though I can see in your commit that you referenced that you're handling some casting scenarios with generic in the ArkCreature, I feel the underline issue is related to the underline types as they are being loaded and read.

and actually, from that referenced commit alone, it's unclear to me how a negative value in a signed byte could be casted to unsigned byte without erroring.. potentially you have more changes for me to review on than that one commit alone ?

flagoss commented 4 years ago

My knowledge about programmation is limited. I did those modification last year. The only thing I changed is sbyte to byte. I am running with my modification since then. My servers are all with lvl600 wild dinos and we had no issue with this modification. But like I said I am not a programmer. I don't understand everything you are saying.