search

arkaitzgarro / elastic-apm-laravel

Laravel APM agent for Elastic v2 intake API
MIT License
79 stars 17 forks source link

Default log level to INFO #158

Closed alignwebs closed 2 years ago

alignwebs commented 2 years ago

As per the documentation "The default log level for the agent package is info."

Ref: https://github.com/arkaitzgarro/elastic-apm-laravel#logging

dstepe commented 2 years ago

I wanted to point out that "The default log level for the agent package is info." is a true statement. The underlying agent did does default to INFO, though this class defaulted to ERROR prior to this PR. I'm not sure if the documentation should be updated to clarify the distinction between this package and the agent.

arkaitzgarro commented 2 years ago

I wanted to point out that "The default log level for the agent package is info." is a true statement. The underlying agent did does default to INFO, though this class defaulted to ERROR prior to this PR. I'm not sure if the documentation should be updated to clarify the distinction between this package and the agent.

True, I think we should improve the docs instead, looks we are constantly confusing the underlying agent and this package. In the section where we describe the environment variables, we say the default is error...

Log level for the APM Agent package. Must be PSR-3 compliant. Defaults to error.

I'm going to revert the change and think how to make the docs more clear.