search

arkav / lualine-lsp-progress

LSP Progress lualine componenet
MIT License
227 stars 18 forks source link

fix: adapt to shadmansaleh/lualine breaking changes #6

Closed clason closed 2 years ago

clason commented 2 years ago

The component refactor in https://github.com/shadmansaleh/lualine.nvim/pull/81 introduced some breaking changes that need to be adapted to; this PR makes those changes (due to @shadmansaleh).

Note that this breaks compatibility with the original lualine, but since that has been unmaintained for many months now, I consider Shadman's fork to be the "one true lualine" now.

(Removed the unused util import while I was at it.)

smarquez1 commented 2 years ago

The repo has moved now to: https://github.com/nvim-lualine/lualine.nvim

shadmansaleh commented 2 years ago

The fork has been merged to hoob3rt/lualine. And original hoob3rt/lualine has been moved to nvim-lualine. So this breaking chnage is now present in original repo too . Without this pr merged this plugin won't work with lualine :>

arkav commented 2 years ago

I saw this, but I've been busy over the past week. I did not want to break anyone's configurations so I left it on the back burner was considering putting on a sep branch/dep warning. Now its default in lualine. Thanks for the contributions, merged.