search

arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
108 stars 14 forks source link

Item category not updated correctly under certain conditions #1098

Closed antarek closed 6 years ago

antarek commented 6 years ago

Hi,

I added a rule to ArkInventory to have all items from 3 different sets under the Set gategory and if all is ok when i place an item tagged as being part of one of these 3 sets when i change this item to replace him with a bette one and untag him as part of one of these 3 sets then the item remains into the Set category as if ArkInventory failed to update its status. I tried to switch the sorting option to instantly but it doesn't seem to solve the issue.

My rule to group all items from my 3 different sets is:

I don't understand why items that aren't anymore tagged as being part of any of these 3 sets remain in my Set category.

arkayenro commented 6 years ago

if you go into edit mode and click on the item which category is it assigned to?

antarek commented 6 years ago

The current value is set to the rule that i created for items that belong to one of my 3 sets. The default value is set to systeme > [0416] equipable items (bound).

And as you can see in the screenshot posted just below an item that is no longer part of any of my 3 sets remains into the category that i created for set items instead of moving to the "objets équipables (lié)" (equipable items (bound)) one.

Screenshot link here: https://i.imgsafe.org/ab/ab1a6f24d4.jpeg

Note that once that i disconnect to the character screen and log back these items are moved into the correct category. As i said before it's as if ArkInventory failed to update the status of these items until that i disconnect.

arkayenro commented 6 years ago

are you using an outfit mod, if so which one, or just the blizzard equipment manager?

antarek commented 6 years ago

No outfit mod at all. I m using the Blizzard equipment manager.

Here are the mods that i have installed in addition to ArkInventory:

arkayenro commented 6 years ago

its possible there is a delay between the item being placed back into your bags - which is when it gets categorised - and the equipment set being updated.

you should be able to just pick it up and move it to any other slot to regenerate its category again, and if that works then there is enough of a delay in the equipment sets getting updated to cause the issue

antarek commented 6 years ago

Just tested to move the item to the default category but it moves it back to the set one so ArkInventory continues to think of the item as if it was still part of any of my 3 equipment sets. Really weird. So far, as saif above, the only way to have the item set to its correct category is to log back to the character screen and then login back.

arkayenro commented 6 years ago

ok, i'll take a look at the code when i get home. its possible blizzard changed something in the equipment manager and as i use outfitter i didnt notice

arkayenro commented 6 years ago

i think its was the delay as i immediately recalcualte so if its even slightly off it wont update correctly

i've changed the code to flag the window for redraw, not actually redraw it so by the time it gets redrawn it should have had time for the equipment sets to have updated

antarek commented 6 years ago

A little update, i just noticed that pressing the "empiler les objets" (stack items) button moves items that do not belong anymore to any of my 3 sets to their correct category.

hollo6 commented 6 years ago

I'm having the same issue, using r781 ATM. I have 1 rule for the sets (outfit() ), no equipment manager mods. After removing any item from any set, nothing puts it into the correct category except a /reload. This problem is present for months now, I think it started around the prepatch.

arkayenro commented 6 years ago

found the problem, will be fixed next release

hollo6 commented 6 years ago

With r782 still need to reopen the bag (it did update right away before) but now at least reload is not necessary.

antarek commented 6 years ago

Just for info i m using Akrinventory v3.08.13 (using the Twitch app to update addons and having set the app to download alpha builds).

For the moment i m still having the same error message when i try to add any outfit( ) rule (screenshot below).

https://i.imgsafe.org/d0/d06b08a40c.jpeg

arkayenro commented 6 years ago

what have you got for rule 1001? and what are the names of all your equipment sets?

also, how comfortable are you with editing one of the files?

could you edit ArkInventoryRules\ArkInventoryRules.lua - line 972 local setname = C_EquipmentSet.GetEquipmentSetInfo( setid )

add this underneath it ArkInventory.Output( setid, " = [", setname, "] [", type( setname ), "]" )

then load the game and see what gets output when you open the bag

arkayenro commented 6 years ago

you might also just want to double check and disable every single mod except arkinventory and see if it still has issues

antarek commented 6 years ago

Removing the "--" before the line 972 to have this "ArkInventory.Output( setid, " = [", setname, "] [", type( setname ), "]" )" taken into account worked. With this change my set items are placed into the correct category.

The only little issue is that it spams my chat with lines like this one for every registered sets : "Arkinventory: X = [set name] [string]" everytime i open my bag.

Anyway this is already a big step forward so thanks a lot arkayenro.

arkayenro commented 6 years ago

you can put the -- back in front of line 972 if you want as that line wont make any difference, its just output. line 973 was added to try and fix it, which it appears to have done.

did the output show every set id having a name and a type of String?

antarek commented 6 years ago

Ok, thanks and yes it shows every set ID.

Here is what it says for my mage that has 3 sets saved into the default Blizzard equipment manager for exemple:

https://i.imgsafe.org/f8/f8c75773f7.jpeg

Anyway, once again, thanks for helping.

arkayenro commented 6 years ago

fixed in 3.08.13