arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
108 stars 14 forks source link

[BUG] Frame Rate drops massively when search is used and never recovers #1620

Open larilille-wow opened 1 year ago

larilille-wow commented 1 year ago

What version number you are using? 3.10.00-alpha-17 but it's happened in every release since wrath launched

What game client are you playing? Retail, Burning Crusade, Classic / Live, PTR, Beta Wrath Classic

What language is the game client set to? English

Describe the bug If I try and search then my frame rate drops massively (from 100 to below 20, often below 2) and the game becomes unresponsive. After a while a long list of [?] items appears in the search; but frame rate never recovers until I reload my UI.

To Reproduce Search

Screenshots WoWScrnShot_102422_102906

Additional context I tried deleting all my account and character data and the issue still occurs (although it's not quite as bad), screenshot was taken after doing that.

stratoru commented 1 year ago

The last few alpha versions have been bugged heavily for WotLK, with any item changes during combat absolutely sinking frame rate, such as using a combat potion, swapping equipped weapon from bag, etc. Would recommend reverting to alpha version 13 (from 10/16/22) for now, until WotLK is properly tested/supported by all the upcoming changes. All versions since the alpha version 14 (10/19/22) have been unstable.

arkayenro commented 1 year ago

the only reason for search to constantly update is due to an unknown item in your data that will never return values. did you copy across your saved variable file from a higher game client? eg retail to wrath?

open the config and enable debug (top of the screen), then open the search and see if it spits anything about unknown items

Kdcargill commented 1 year ago

This appears to be happening outside of just searching. When making potions, picking up items from mobs on the ground, or just basically anything that has to do with new items appearing in the bags, I'm getting this to happen to me. I have confirmed that it is ArkInventory because when I turn the addon off everything goes back to normal and I get more than 6 fps.

arkayenro commented 1 year ago

@Kdcargill to confirm you turned off all your other mods and just had arkinventory running and it lagged when crafting/looting?

can you enable debug and loot/craft something and let me know what takes a long time

Kdcargill commented 1 year ago

Sure. I can confirm that the lag does happen even with all other addons turned off (although not nearly as bad). This snippet was from me buffing myself with a greater blessing, thus using a reagent, and making my inventory update.

Edit: Going to expand here on what the 'lag' is. In this instance, it's probably about a .5sec studder of the entire game. However, when I have my addons turned on, it's roughly about 3-5sec of reduced framerate (anywhere from 3-10fps).

image

arkayenro commented 1 year ago

so you used something, it scanned and updated then nothing else in the debug logs?

nothing is constantly looping?

and this is in wrath?

Kdcargill commented 1 year ago

That was all that happened when I buffed, it doesn't appear that anything is constantly looping. This also happens when looting, or creating things. This is in WotLK. I'm using v31000.Dragonflgith Alpha.18[Wrath of the Lich King].

arkayenro commented 1 year ago

try 3.10.01 alpha 1

if its not looping then it looks normal.

i cant duplicate it, i can spin around and move items in my bags and no mini lag spike

could you try config > advanced > threads > debug youll get a lot of garbage but youre looking for something that keeps looping, like objectdata, or anything that takes more than a couple of millseconds.

Kdcargill commented 1 year ago

3.10.01 alpha 1 seems to have fixed this issue, not getting anymore frame drops when I loot an item or inventory changes.

garylisk commented 1 year ago

Been having frame rate drops very regularly in WoW Classic and it coincided with me getting a new graphics card, so I thought maybe that was it. However, it appears that they go away if I disable ArkInventory. It is most noticeable when looting from mobs but it can happen just for no reason at all.

What version number you are using? 3.10.02 but it's happened in every release since wrath launched

What game client are you playing? Retail, Burning Crusade, Classic / Live, PTR, Beta Wrath Classic

What language is the game client set to? English

Describe the bug See above. I will say that I have my inventory heavily sorted, including some custom rules. I almost wonder if it is lagging as it tries to sort new items into my very sorted inventory.

To Reproduce Loot mobs, or just walk around. I have several video clips saved I can provide. I have not tried to reproduce it with "purely" ArkInventory where all other addons are disabled, but I can.

Kdcargill commented 1 year ago

I can confirm that this is actually still going on. I thought it had gone away but what actually happens is that after you do a reload (or start up the game for the first time) the lag seemingly goes away but slowly starts to come back with time played. To me it seems the longer you play without a reload, the worse this lag is. Prepotting before a fight in the tail end of a raid basically stalls the game out for 5seconds.

Edit: worth noting, I’ve tried I raid with Arkinventory turned off and just used the elvui bags and didn’t experience any lag whatsoever.

garylisk commented 1 year ago

Can confirm also that using any other inventory addon is freaking poverty, I can't find anything in Bagnon. Friends be like "Sort button bro" and I am like "This is what you deal with???"

arkayenro commented 1 year ago

3.10.03 should have fixed this, anyone still having the issue?