arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
108 stars 14 forks source link

[BUG] FPS Bug when opening inventory #1792

Open mburke364 opened 1 year ago

mburke364 commented 1 year ago

What version number you are using? ArkInventory-3.10.16 Release

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta Retail

What language is the game client set to? English

Describe the bug Any time I open by inventory with ArkInventory enable since the 10.1 WoW patch my FPS drops from 144 cap to 10 FPS. FPS recovers to normal after ~3-4 seconds of ArkInventory being closed.

chedster commented 1 year ago

Adding to this, I'm seeing the same issue in Classic WoTLK as well. It's been happening since Sunday - which is coincides with the ArkInventory-3.10.16 Release

Edit/Update: I downgraded by to 3.10.15 Release and am still seeing the same issue

BeeJayJayn commented 1 year ago

+1

Ianni commented 1 year ago

can second this for wotlk classic. Maybe to add to the description, it is not just a massive fps drop 200 -> 15 it also most of the times has a memory usage spike of arkinventory. at some point it clears the used memory and the bags are usable again for 1 or 2 "openings"

spacegoatmcgoat commented 1 year ago

Experiencing the same. This appears to be the cause:

2x ArkInventory/Core/ArkInventory.lua:12515: script ran too long
[string "@ArkInventory/Core/ArkInventory.lua"]:12515: in function `ThreadResume'
[string "*ArkInventory.xml:2507_OnUpdate"]:4: in function <[string "*ArkInventory.xml:2507_OnUpdate"]:1>

Locals:
threads = <table> {
 p05-draw-1 = <table> {
 }
 p08-tooltip = <table> {
 }
}
tz = 92991937.949700
(for generator) = <function> defined @ArkInventory/Core/ArkInventoryConst.lua:227
(for state) = <table> {
 1 = "p05-draw-1"
 2 = "p08-tooltip"
 idx = 1
 tbl = <table> {
 }
}
(for control) = "p05-draw-1"
thread_id = "p05-draw-1"
data = <table> {
 duration = 12128.315400
 resumed = 92991937.949700
 thread = <no value>
}
ok = false
errmsg = "ArkInventory/Core/ArkInventory.lua:10784: script ran too long"
(*temporary) = false
(*temporary) = "ArkInventory/Core/ArkInventory.lua:10784: script ran too long"
(*temporary) = false
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "script ran too long"
type = <function> defined =[C]:-1
error = <function> defined =[C]:-1
string = <table> {
 split = <function> defined =[C]:-1
 match = <function> defined =[C]:-1
 gmatch = <function> defined =[C]:-1
 upper = <function> defined =[C]:-1
 gsub = <function> defined =[C]:-1
 format = <function> defined =[C]:-1
 utf8sub = <function> defined @ElvUI_Libraries/Core/UTF8/utf8.lua:157
 lower = <function> defined =[C]:-1
 sub = <function> defined =[C]:-1
 len = <function> defined =[C]:-1
 utf8lower = <function> defined @ElvUI_Libraries/Core/UTF8/utf8.lua:250
 gfind = <function> defined =[C]:-1
 join = <function> defined =[C]:-1
 rep = <function> defined =[C]:-1
 utf8len = <function> defined @ElvUI_Libraries/Core/UTF8/utf8.lua:132
 char = <function> defined =[C]:-1
 rtgsub = <function> defined @FrameXML/RestrictedInfrastructure.lua:618
 utf8upper = <function> defined @ElvUI_Libraries/Core/UTF8/utf8.lua:240
 reverse = <function> defined =[C]:-1
 byte = <function> defined =[C]:-1
 trim = <function> defined =[C]:-1
 utf8reverse = <function> defined @ElvUI_Libraries/Core/UTF8/utf8.lua:260
 find = <function> defined =[C]:-1
}
spacegoatmcgoat commented 1 year ago

I noticed some of the lines in the error I posted previously referenced elvui, so i disabled elvui and tried again -- no longer able to reproduce the problem.

I also use addonskins in elvui...and arkinventory was enabled. I disabled arkinventory image like so.

which appears to have resolved the issue for me after some brief testing.

So if you are experiencing this and are an elvui addonskins user, turn it off for arkinventory.

Tagging all of you that reported this to see if this is your issue as well. @mburke364 @Ianni @BeeJayJayn @chedster

SirManbeard commented 1 year ago

I noticed some of the lines in the error I posted previously referenced elvui, so i disabled elvui and tried again -- no longer able to reproduce the problem.

I also use addonskins in elvui...and arkinventory was enabled. I disabled arkinventory image like so.

which appears to have resolved the issue for me after some brief testing.

So if you are experiencing this and are an elvui addonskins user, turn it off for arkinventory.

Tagging all of you that reported this to see if this is your issue as well. @mburke364 @Ianni @BeeJayJayn @chedster

Brilliant!

chedster commented 1 year ago

@spacegoatmcgoat Does the latest AddonSkins release (4.66) resolve this issue without having to disable the skinning? Their latest changelog has a few skin related fixes:

Fix Skin Loading Logic
Fix Ace3 Skin

EDIT: Can confirm that it still happens with the new version. Best to continue disabling it in AddonSkins.

spacegoatmcgoat commented 1 year ago

@chedster I was running 4.66 last night, and as your edit confirmed, it does occur on that version.

Sekenx commented 1 year ago

Also experienced this issue

JoeyJFranklin commented 1 year ago

I also get the error spacegoatmcgoat linked and I don't use Elvui or AddonSkins