arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
108 stars 14 forks source link

[BUG] Currency not displayed #1818

Open Krarkvar opened 1 year ago

Krarkvar commented 1 year ago

What version number you are using? 3.10.17

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta Classic

What language is the game client set to? ENG

Describe the bug Although the box is checked in the settings, no currency is displayed, even though if arkinvenctory is the only addon enabled.

To Reproduce

Screenshots https://ibb.co/L9Q9Cyw https://ibb.co/sjDzYhR https://ibb.co/QnVcVV5

Additional context Add any other context about the problem here. BUG2 BUG BUG3

Serverfrog commented 10 months ago

Any Progress here? or what the cause of the problem could be? as it wont fire an error. So is the API from Blizzard not giving the information?

Serverfrog commented 10 months ago
[20:50:19.997828]  draw starting [1] new thread, state=4
[20:50:19.997860]  draw starting [2] new thread, state=0
[20:50:19.997881]  draw starting [4] new thread, state=0
[20:50:19.997900]  draw starting [8] new thread, state=0
[20:50:19.997920]  draw starting [16] new thread, state=0
[20:50:19.997940]  draw starting [9] new thread, state=0
[20:50:19.997957]  draw starting [5] new thread, state=0
[20:50:19.997975]  draw starting [10] new thread, state=0
[20:50:19.997993]  draw starting [3] new thread, state=0
[20:50:19.998011]  draw starting [6] new thread, state=0
[20:50:19.998028]  draw starting [13] new thread, state=0
[20:50:19.998044]  draw starting [7] new thread, state=0
[20:50:19.998061]  draw starting [14] new thread, state=0
[20:50:19.998078]  draw starting [15] new thread, state=0
[20:50:20.028333]  draw location 1 started
[20:50:20.067292]  draw location 1 complete p05-draw-1 took 39ms
[20:50:20.099216]  draw location 10 started
[20:50:20.099280]  draw location 10 complete p05-draw-10 took 0ms
[20:50:20.132251]  draw location 13 started
[20:50:20.132311]  draw location 13 complete p05-draw-13 took 0ms
[20:50:20.165145]  draw location 14 started
[20:50:20.165205]  draw location 14 complete p05-draw-14 took 0ms
[20:50:20.197483]  draw location 15 started
[20:50:20.197546]  draw location 15 complete p05-draw-15 took 0ms
[20:50:20.230422]  draw location 16 started
[20:50:20.230481]  draw location 16 complete p05-draw-16 took 0ms
[20:50:20.262918]  draw location 2 started
[20:50:20.262977]  draw location 2 complete p05-draw-2 took 0ms
[20:50:20.296139]  draw location 3 started
[20:50:20.296193]  draw location 3 complete p05-draw-3 took 0ms
[20:50:20.328787]  draw location 4 started
[20:50:20.328848]  draw location 4 complete p05-draw-4 took 0ms
[20:50:20.361138]  draw location 5 started
[20:50:20.361201]  draw location 5 complete p05-draw-5 took 0ms
[20:50:20.393820]  draw location 6 started
[20:50:20.393879]  draw location 6 complete p05-draw-6 took 0ms
[20:50:20.426213]  draw location 7 started
[20:50:20.426272]  draw location 7 complete p05-draw-7 took 0ms
[20:50:20.459043]  draw location 8 started
[20:50:20.459103]  draw location 8 complete p05-draw-8 took 0ms
[20:50:20.492232]  draw location 9 started
[20:50:20.492292]  draw location 9 complete p05-draw-9 took 0ms

Debug Output when enabling currency

Serverfrog commented 10 months ago

Ok. @arkayenro : ArkInventory.lua:810 -> "FIX ME when did the currency tab turn up?" Wrath

That lets me see my currency... You can then remove the Fixme because now you know its in Wrath where the currency tab turned up ;)

Also: ArkInventoryTooltip:262 -> tooltip:SetCurrencyByID( osd.id, osd.amount )

to

                if osd.amount then
                    tooltip:SetCurrencyByID( osd.id, osd.amount )
                end

As it seems, there are osd with class currency which wont have the field amount