arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
108 stars 14 forks source link

[BUG] Long loading times when used in conjunction with WeakAuras #1839

Closed cdmichaelb closed 9 months ago

cdmichaelb commented 10 months ago

What version number you are using? 3.10.19

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta Classic

What language is the game client set to? English

Describe the bug When loading wow benchmarking addon load time ArkInventory has a pretty impressive 0.102s, 0.005s, and 0.003s load time. But it causes Weakauras to have a 1.555second load time. Disabling ArkInventory returns WeakAuras to a 0.071s load time.

To Reproduce Steps to reproduce the behaviour, if possible: Use Warmup addon (curseforge) to benchmark addon load times. Enable ArkInventory alongside WeakAuras.

Additional context Link to Warmup

ArkInventory is my favorite bag addon and no other's compare, but the fact that it interacts poorly with WeakAuras forces me to not use it, because as nice as ArkInventory is, WeakAuras is essential in modern (classic) wow.

arkayenro commented 10 months ago

i dont use weak auras so i'd have to go through it to see what its doing.

its most likely because im force loading a lot of blizzard addons up front that normally only load when you open them (bank, void, tradeskills/professions, collections, auctions). it might cause wa to need to do more stuff during load time.

arkayenro commented 10 months ago

eg check your warmup results when arkinventory is NOT loaded and see if any of these are in there Blizzard_Collections Blizzard_Professions Blizzard_TradeSkillUI Blizzard_GuildBankUI Blizzard_VoidStorageUI

then load arkinventory as well and see which ones are in there now.

if weak auras hooks into any of those then it will need to initialise whatever it needs to, to support those addins which will take more time.

arkayenro commented 10 months ago

tested and its not those, but i can force weakauras to load before arkinventory and it seems to fix the issue

with the game shut down edit your ArkInventory_Vanilla.toc file find the line that starts with ## OptionalDeps: add , WeakAuras to the end of it

load the game

arkayenro commented 9 months ago

fixed in 3.10.20