arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
102 stars 14 forks source link

[BUG] fresh installation fails due to nil cache #1852

Open kdtresh opened 6 months ago

kdtresh commented 6 months ago

What version number you are using? 3.10.22

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta Classic SOD

What language is the game client set to? EN-US

Describe the bug Fresh installation of the game, fresh installation of ArkInventory via CurseForge. Error in ArkInventoryCollectionReputation.lua:593 if cache[id].index ~= index then Unfortunately, there is no cache[id] so it dies. Putting the section in an if cache[id] then ... end block fixed it, though there are several other spots in the file that dereference cache[id] without checking to make sure it's not nil that I had to fix before it would load without error.

To Reproduce Steps to reproduce the behaviour, if possible: Fresh install of both, possibly just remove cache and try to load; I did not try to reproduce after I fixed it.

Screenshots If applicable, add screenshots to help explain your problem. N/A

Additional context Add any other context about the problem here. N/A, just need some nil checks.

arkayenro commented 6 months ago

should be fixed when the next release comes out