search

arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
102 stars 14 forks source link

EquipLocation [INVTYPE_NON_EQUIP_IGNORE] not coded. #1871

Closed Crelam closed 3 months ago

Crelam commented 3 months ago

What version number you are using? 3.1025 (Dragonflight)

What game client are you playing? Retail, Wrath, Classic / Live, PTR, Beta Live

What language is the game client set to? English

Describe the bug A clear and concise description of what the bug is. Lots of my bars are empty, like everything been filtered out.

Also receiving message: ArkInventory: WARNING> EquipLocation [INVTYPE_NON_EQUIP_IGNORE] not coded, please let the author know.

To Reproduce Steps to reproduce the behaviour, if possible: I just loaded into the game and saw that warning spamming my chatbox. 😅

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

LilliCat commented 3 months ago

Untitled

Same issue on live retail. In addition, many "non-equipment" items (consumables, herbs, meat, ores, etc) and in this example, Swiftthistle is incorrectly being assigned

ImUnicke commented 3 months ago

This was not an issue in v31024 (or at least prior to 10.2.6 Retail patch). But reverting to this version retains the issue. Reverting to v31023 retains the issue.

Maybe data was corrupted of our settings 😢

ImUnicke commented 3 months ago

Oh no, I think Blizz broke their GetItemInfo API 😩 It's now returning the INVTYPE_NON_EQUIP_IGNORE instead of one of these values https://warcraft.wiki.gg/wiki/Enum.InventoryType

Hmmm adding the new value into the ArkInventoryConst.lua resolves the chat warning, but the Items in bags continue to filter incorrectly.

            -- stuff that needs to exist, but not get shown
            ["INVTYPE_NON_EQUIP"] = 0,
            ["INVTYPE_NON_EQUIP_IGNORE"] = 0,
            ["INVTYPE_BAG"] = 0,
ImUnicke commented 3 months ago

v31026 fixes the chat error spam due to the missing item equip type, but the default Item category choices are mostly wrong still. Tons of Items are now default-categorized as Equipment [(Soulbound)] whereas they were previously Recipes/Potions/Consumables/etc.

arkayenro commented 3 months ago

yeah, it looked ok but there were some oddities that i missed. just trying to work out the best way to fix it forever

arkayenro commented 3 months ago

should be properly fixed in 3.10.27

GarnetDivine commented 3 months ago

Same issue for me, I see 3.10.27 listed on CurseForge, but when I install/update, it is still 3.10.26.

Edit: scratch that, had to manually download the file and install it rather than use CurseForge.

ImUnicke commented 3 months ago

Item default categories seem back to normal in v31027.

Think this issue can be closed.