arkayenro / arkinventory

A World of Warcraft Inventory mod for Retail, Burning Crusade, and Classic
108 stars 14 forks source link

Stack Compression - Proof of Concept feedback required #1874

Closed arkayenro closed 2 months ago

arkayenro commented 5 months ago

i've started to add a stack compression option, basically you only see one stack of each item (even equipment or items that dont normally stack).

if theres only one stack of the item then nothing changes.

if theres more than one stack its now displayed differently

how it ends up being identified is up for grabs, i dont really have a set idea on how it should look, so if you have a better idea let me know (it could also be a config option).

on entering a compressed item a popup bar is shown that contains all of the actual items which act like normal item slots would. its border and background come from the underlying bar the items were on.

after entering a compressed item the popup bar will remain visible until you either

theres currently not a lot of configurable options for it yet but the internal/external padding is currently hardcoded to 8. i expect once its settled down the options will become accessible.

arkayenro commented 5 months ago

available for testing in 3.10.27 alpha 2

ki-88 commented 4 months ago

Hi, thank you for adding this option seems to work with no issues so far. I would prefer if there is an option to stack unstackable items or stack stackable items Meaning for example, I can choose to only stack items such as armor (unstackables) while keep others default such as cloth (stackables) or vesa versa or both.

Also, it would be great to add the ability interact with the stacked items with left click just like normal. Such as consuming an item or picking an amount of a stack to move it around for trade or simply drag. And the ability to disable the pop-up. I personally think the pop-up is not needed as long as I can interact with the items like normal. Upon dragging I would drag the highest stack available, or shift+click to pick amount and drag aside..etc. I would also prefer auto restack (stackable items) so that I do not end up having various stack size of the same item that would take more space without seeing it (should occur after closing/opening bags)

I think empty slots does not need the pop-up bar as there is no item to choose from.

For me I would happy by the current implementations but if possible to implement the above would be great.

Cheers,

arkayenro commented 4 months ago

i've added options for empty, single, and stacks, in the next alpha

i cant make the compressed stack interactive at the moment. the underlying code was never designed to virtualise the slots, it maps them one to one and just shows them in a different order and hides the ones you dont want to see.

essentially ive now got two mapped slots for each real one (a normal one and a compressed one) and where i tag the normal slot as compressed i show the compressed slot instead. the popup frame is all the normal slots being displayed in there instead of the main window (im just moving things around).